Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Comment module load Update #118

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Aug 26, 2024

This PR updates the deployment comment and updates the tagging logic also.

In this PR:

Closes #114

Copy link
Contributor

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git tag changes look good to me! Just have a question re module directory

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: jo-basevi <[email protected]>
Signed-off-by: Tommy Gatti <[email protected]>
@CodeGat CodeGat requested a review from jo-basevi August 27, 2024 00:53
Copy link
Contributor

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 05cf79e into main Aug 27, 2024
@CodeGat CodeGat deleted the 114-module-comment-update branch August 27, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deployment comment to reflect the removal of .../vk83/modules/access-models
3 participants